*** lelkneralfaro has joined #novawebdev | 09:14 | |
*** jelkner has joined #novawebdev | 10:30 | |
*** replaceafill has joined #novawebdev | 10:32 | |
*** zOnny has joined #novawebdev | 11:18 | |
*** mr_german has joined #novawebdev | 12:18 | |
mr_german | good morning replaceafill | 12:19 |
---|---|---|
replaceafill | good morning mr_german | 12:19 |
mr_german | replaceafill, I *fixed* my facebook plugin story | 12:23 |
replaceafill | mr_german, please read the article about naming IDs and classes in CSS!!! | 12:27 |
replaceafill | mr_german, "seventy-five-width-size"!??!??!? | 12:27 |
replaceafill | mr_german, and you write twen*t*y, not tweny | 12:28 |
replaceafill | mr_german, so much $$$ wasted on English courses >.< | 12:28 |
replaceafill | mr_german, you force-pushed your branch, right? | 12:32 |
mr_german | no | 12:34 |
replaceafill | mr_german, never mind, i got a conflict pulling from my old local branch | 12:35 |
replaceafill | mr_german, but i was able to see the change | 12:36 |
replaceafill | mr_german, good work, change has been deployed to production and testing | 12:42 |
mr_german | replaceafill, my apologies for the inconvenience :'( | 12:43 |
replaceafill | mr_german, you need to work on your naming skills | 12:43 |
replaceafill | mr_german, if tomorrow AEA asks for the sidebar to be 20% width your selectors are doomed | 12:44 |
replaceafill | s/AEA/ORA | 12:44 |
replaceafill | mr_german, don't use presentation for naming, use structure | 12:44 |
replaceafill | mr_german, presentation: colors, sizes, positions | 12:45 |
replaceafill | mr_german, structure: parts, components of a page | 12:45 |
replaceafill | mr_german, 25% or full-width are referring to sizes, so presentation, so not good | 12:45 |
replaceafill | mr_german, main-content or secondary-content refer to structure, so better | 12:46 |
mr_german | definitely, i need to learn that | 12:47 |
replaceafill | mr_german, please track your AEA hours here: https://docs.google.com/spreadsheets/d/14MKRBeS_Mv-Y7uCi1ZYNsZE5JIW5ahs9yla7i22x21E/edit#gid=0 | 12:49 |
mr_german | replaceafill, in total since the last year or .. ' | 12:50 |
mr_german | ? | 12:50 |
mr_german | oh | 12:50 |
mr_german | nvm | 12:50 |
replaceafill | mr_german, this month | 12:50 |
mr_german | replaceafill, ok | 12:50 |
mr_german | replaceafill, brb | 12:50 |
replaceafill | mr_german, and your ORA hours here: https://docs.google.com/spreadsheets/d/1WOIL2BsZOH6T_RNjsdEeIwSzMStdQ9oM2FGoIKiujSg/edit#gid=0 | 12:51 |
replaceafill | mr_german, btw, i'm using US/Eastern times in those sheets | 12:53 |
replaceafill | mr_german, but you're free to write your times however you prefer | 12:53 |
zOnny | hey replaceafill | 13:08 |
replaceafill | hey zOnny | 13:08 |
zOnny | replaceafill, there is a way to change the logo through the tendenci templates | 13:09 |
zOnny | replaceafill, I found the template but doesn't make any change :( | 13:10 |
replaceafill | zOnny, what are you trying to do exactly? | 13:10 |
zOnny | replacaefill, change tendeci logo, which easily can be changed in the UI | 13:11 |
replaceafill | zOnny, you're not being clear, change what logo? | 13:12 |
replaceafill | zOnny, in what project, in what theme? | 13:12 |
zOnny | replaceafill, top left corner | 13:12 |
replaceafill | sigh... | 13:13 |
replaceafill | zOnny, top left corner of what? | 13:13 |
replaceafill | zOnny, i don't understand what project you are referring to | 13:13 |
replaceafill | zOnny, is there a gitlab issue you can point me to? a screenshot? anything... | 13:14 |
zOnny | ls | 13:15 |
*** mjsir911 has joined #novawebdev | 13:38 | |
*** zOnny has joined #novawebdev | 13:42 | |
zOnny | replaceafill, I want to make couple things clear | 13:45 |
replaceafill | zOnny, please | 13:45 |
zOnny | replaceafill, having the tendenci2018 in themes means that it will be the web-page for NOVALACIRO? | 13:46 |
replaceafill | zOnny, no | 13:47 |
replaceafill | zOnny, for NOVALACIRO you'll design a new theme | 13:47 |
replaceafill | zOnny, don't be trying to tweak/customize tendenci2018 | 13:47 |
replaceafill | zOnny, you'll be suffering a lot if you do that | 13:47 |
zOnny | replaceafill, As we did for ORA right ? | 13:47 |
replaceafill | zOnny, yes | 13:47 |
replaceafill | zOnny, and recently for NEA4OR | 13:48 |
replaceafill | zOnny, if you want to start something *now* check the initial commits in any of those themes | 13:48 |
zOnny | ok, replaceafill | 13:49 |
replaceafill | zOnny, from tendenci2018 you need to pick up concepts like pages, boxes, navbars | 13:49 |
zOnny | step by step ... replaceafill :) | 13:50 |
lelkneralfaro | zOnny, | 14:02 |
lelkneralfaro | zOnny, you there? | 14:02 |
zOnny | hey lelkneralfaro | 14:03 |
lelkneralfaro | zOnny, I just set up my own main email account, so that I can send from support@novawebdevelopment | 14:04 |
lelkneralfaro | zOnny, and I think that replaceafill was right, it is better that it not say it is sending from your own name | 14:04 |
lelkneralfaro | zOnny, I put Nova Web Support; Louis Alfaro as the name. I'll send you an email as an example | 14:05 |
lelkneralfaro | zOnny, maybe you can put Nova Web Support; Edzon Quinteros | 14:05 |
lelkneralfaro | zOnny, or Nova Web Support; Edzon | 14:05 |
zOnny | lelkneralfaro, | 14:05 |
zOnny | lelkneralfaro, I will | 14:06 |
lelkneralfaro | zOnny, cool thanks zOnny that's all | 14:06 |
zOnny | lelkneralfaro, The thing is, I don't know how ? :S | 14:08 |
zOnny | lelkneralfaro , I will figure out | 14:09 |
zOnny | lelkneralfaro, done | 14:14 |
mr_german | ACTION is back | 14:15 |
zOnny | hey mr_german good to have you back | 14:16 |
mr_german | hey zOnny ;) | 14:17 |
lelkneralfaro | zOnny, sorry I went away | 14:18 |
lelkneralfaro | zOnny, you figured it out? | 14:18 |
zOnny | yep, lelkneralfaro | 14:21 |
lelkneralfaro | zOnny, just got the mail. thanks | 14:21 |
zOnny | replaceafill, there is a reason why you choosed private repos for the other ones ? | 15:04 |
replaceafill | zOnny, for the other ones? | 15:04 |
zOnny | replaceafill, ORA and NEA4OR theme | 15:06 |
replaceafill | zOnny, no reason, we're just developing them internally | 15:06 |
mr_german | replaceafill, are you there? | 16:24 |
replaceafill | mr_german, yes | 16:24 |
mr_german | are you calling me??? | 16:24 |
replaceafill | mr_german, sorry it was an accident | 16:25 |
replaceafill | mr_german, my phone got unlocked | 16:25 |
mr_german | replaceafill, oh, ok | 16:25 |
mr_german | do not worry | 16:25 |
replaceafill | :) | 16:25 |
*** jelkner has joined #novawebdev | 16:36 | |
*** mjsir911 has joined #novawebdev | 16:36 | |
*** jelkner has joined #novawebdev | 16:37 | |
*** jelkner has joined #novawebdev | 16:39 | |
*** zOnny has joined #novawebdev | 16:41 | |
*** zOnny_ has joined #novawebdev | 16:44 | |
jelkner | Good afternoon, replaceafill! | 16:49 |
replaceafill | jelkner, good afternoon | 16:50 |
jelkner | who will be starting the hangout? | 16:50 |
replaceafill | jelkner, not sure | 16:50 |
jelkner | 9 minutes to go | 16:51 |
jelkner | i'm ready to start now ;-) | 16:51 |
replaceafill | jelkner, ready | 17:00 |
jelkner | me too | 17:00 |
jelkner | https://www.alec.org/ | 17:50 |
*** louisea has joined #novawebdev | 17:50 | |
*** zOnny has joined #novawebdev | 18:13 | |
zOnny | hey replaceafill | 18:29 |
replaceafill | hey zOnny | 18:29 |
zOnny | replaceafill, I have seen the issue#10 | 18:30 |
jelkner | ACTION signs off for the day | 18:30 |
replaceafill | links zOnny links! | 18:33 |
replaceafill | zOnny, you can paste links *here* | 18:33 |
replaceafill | zOnny, :) | 18:33 |
zOnny | https://gitlab.com/novawebdevelopment/tendenci-theme-ora/issues/10 | 18:33 |
replaceafill | zOnny, thank you!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | 18:33 |
replaceafill | :D | 18:33 |
replaceafill | zOnny, ah ok | 18:34 |
replaceafill | zOnny, so you were able to reproduce? | 18:34 |
zOnny | removing the css , this is what I have replaceafill | 18:34 |
zOnny | I sent you a picture. | 18:34 |
replaceafill | zOnny, right | 18:34 |
replaceafill | zOnny, you see the edit options now because i added them yesterday | 18:35 |
zOnny | ok, replaceafill | 18:35 |
replaceafill | zOnny, those need styling too, but that's not a high priority at this point | 18:35 |
replaceafill | zOnny, fixing the tinymce descriptions is | 18:35 |
zOnny | which is your high priority replaceafill | 18:35 |
replaceafill | zOnny, do you need anything to get started? | 18:36 |
replaceafill | zOnny, issue#10 :) | 18:36 |
replaceafill | zOnny, have you tried to reproduce this with the tendenci2018 theme? | 18:37 |
replaceafill | zOnny, i think the issue is there too | 18:37 |
zOnny | :S replaceafill | 18:37 |
zOnny | we are talking about issue#10 right ? | 18:37 |
replaceafill | zOnny, yes | 18:37 |
zOnny | I read and I read you issue but what is your expectation about that template ? replaceafill | 18:38 |
replaceafill | zOnny, ok... when you add an event | 18:39 |
replaceafill | zOnny, you don't add a speaker, right? | 18:39 |
replaceafill | zOnny, but the speaker box is rendered | 18:39 |
zOnny | yep, | 18:39 |
replaceafill | zOnny, that shouldn't happen | 18:39 |
zOnny | right | 18:39 |
replaceafill | zOnny, same with the location | 18:39 |
zOnny | ahh ok, replaceafill | 18:40 |
replaceafill | zOnny, if you inspect the html using the developer tools in the browser | 18:40 |
replaceafill | zOnny, you'll see the description field being rendered | 18:40 |
replaceafill | zOnny, like this: <div class="organizer-desc-short"> | 18:40 |
replaceafill | <p></p><p> </p><br><div id="selenium-highlight"> </div><p></p> | 18:40 |
replaceafill | </div> | 18:40 |
replaceafill | zOnny, those are only whitespaces | 18:41 |
zOnny | and you don't want that whitespaces right ? replaceafill | 18:41 |
replaceafill | zOnny, no | 18:41 |
replaceafill | zOnny, they shouldn't be there | 18:41 |
replaceafill | zOnny, do you understand the task now? | 18:44 |
zOnny | replaceafill, I am blind, i cannot find those tags | 18:52 |
replaceafill | zOnny, the div.organizer-desc-short element shouldn't be there | 18:54 |
replaceafill | zOnny, that's the point | 18:54 |
replaceafill | zOnny, the div.speaker-wrap element shouldn't be there if no speaker was added | 18:54 |
replaceafill | zOnny, that's the point | 18:54 |
replaceafill | zOnny, the exact rendering of the spaces is probably different between firefox and chrome | 18:55 |
zOnny | who is using chrome? replaceafill | 18:55 |
replaceafill | zOnny, i used chrome for filing the issue | 18:55 |
zOnny | checking ..... replaceafill | 18:57 |
replaceafill | zOnny, https://gitlab.com/novawebdevelopment/tendenci-theme-ora/blob/master/templates/events/view.html#L86-118 | 18:58 |
replaceafill | zOnny, see that "for speaker in speakers" | 18:58 |
replaceafill | zOnny, that means the event has at least one speaker set | 18:58 |
replaceafill | zOnny, for the div.speaker-wrap to be rendered | 18:59 |
replaceafill | zOnny, like in your screenshot | 18:59 |
replaceafill | zOnny, and you didn't add one, right? | 18:59 |
replaceafill | zOnny, so the add event for is doing it | 18:59 |
zOnny | is that not good ? replaceafill | 19:00 |
replaceafill | zOnny, no! | 19:01 |
replaceafill | zOnny, because it's rendering unnecessary html elements | 19:01 |
replaceafill | zOnny, like the yellow Speakers box | 19:01 |
replaceafill | zOnny, when there's no speaker! | 19:01 |
zOnny | uhmmmm so, is that the issue about ? replaceafill | 19:05 |
replaceafill | zOnny, yes | 19:05 |
replaceafill | zOnny, we can talk abou this tomorrow | 19:05 |
replaceafill | zOnny, i'm about to leave for the day | 19:05 |
replaceafill | zOnny, we can hang out and i can explain | 19:05 |
zOnny | ok , replaceafill | 19:05 |
zOnny | good rest of the day , replaceafill | 19:06 |
replaceafill | thanks zOnny | 19:06 |
replaceafill | zOnny, see you tomorrow o/ | 19:06 |
*** ubuntourist has joined #novawebdev | 19:43 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!