| anthony_p has quit (Remote host closed the connection) | 01:35 | |
| anthony_p has quit (Ping timeout: 480 seconds) | 07:24 | |
| gabriel_jetro | Greetings everyone | 11:59 |
|---|---|---|
| zOnny | Hello World! | 11:59 |
| thomasboimah | Hello | 11:59 |
| thomasboimah | Yesterday I worked with zOnny on the Secosol blog. Today I will continue working with zOnny. No blockers. | 12:00 |
| thomasboimah | ACTION done | 12:00 |
| zOnny | Yesterday, Thomas and I had a productive time reviewing the blog app for Secosol. Today, we are excited to implement unit and functional tests to ensure that our changes are robust and reliable. No blockers | 12:00 |
| zOnny | ACTION done | 12:00 |
| jelkner | Yesterday i talked with klarios after our meeting and learned that janet may have lots of decidim work sooner than i thought. Today i'll meet with Brandon from May First and talk about promoting the leave big tech campaign from May First in NOVASEN. No blockers. | 12:00 |
| jelkner | ACTION done | 12:00 |
| jelkner | wow, zOnny, that's *GREAT* news! | 12:00 |
| mulbah | Yesterday I was working on the reset password issue for the Todo app | 12:01 |
| mulbah | and I'm testing it now | 12:01 |
| mulbah | ACTION done | 12:01 |
| jelkner | Excellent! | 12:01 |
| jelkner | mulbah, we will need that | 12:01 |
| zOnny | Decidim projects on our way? | 12:01 |
| zOnny | Looking to hear more on that jelkner | 12:01 |
| jelkner | Let me think how to summarize it. | 12:02 |
| jelkner | hold on... | 12:02 |
| gabriel_jetro | jelkner: I've not been assigned yet but yesterday i tried pushing the hope bridge Liberia complete Html repo but I was getting access denied | 12:02 |
| jelkner | thomasboimah, can you please call daniel and see if he can meet now instead of later? | 12:02 |
| thomasboimah | okay | 12:02 |
| jelkner | if he isn't available, i'll meet him when we saud | 12:02 |
| jelkner | said | 12:02 |
| jelkner | but brandon changed the location of our coffee this morning from upper marlboro md to arlington | 12:03 |
| jelkner | so it saves me an hour each way driving | 12:03 |
| jelkner | anyway, i could meet now if he is available | 12:03 |
| jelkner | zOnny, i'm not saying we have any Decidim jobs coming real soon | 12:03 |
| jelkner | we don't actually want them yet, since we aren't ready | 12:04 |
| zOnny | right | 12:04 |
| jelkner | what klarios told me is that janet has been doing a great job learning the system we have | 12:04 |
| jelkner | novasen.org | 12:04 |
| zOnny | Ah. the one that Octree has done | 12:04 |
| jelkner | my job is going to be to engage novasen members in using that | 12:05 |
| jelkner | and in using it myself | 12:05 |
| jelkner | i spoke with klarios yesterday about two ideas i have to use it: | 12:05 |
| zOnny | Yes, that is very important to understand how engaging the system is | 12:05 |
| jelkner | 1. to promote joining May First's "Cutting the Cord" campaign ( https://mayfirst.coop/en/audio/cutting-the-cord/ ) in our group. | 12:06 |
| jelkner | 2. to see if i can interest the ACORE (Arlington Coalition of Rank and file Educators) caucus to use novasen.org decidim to help plan its work. | 12:07 |
| jelkner | 1 will be easier, since have been meeting May First activists in our area (rachael and brandon) who are interested in helping klarios and jelkner in this effort | 12:08 |
| jelkner | and the rest of the NOVASEN group "gets it" in terms of the politics, but they need help "cutting the cord" ;-) | 12:09 |
| jelkner | 2 would be huge | 12:09 |
| jelkner | but i have to see how the rest of the group feels about that | 12:09 |
| jelkner | i have more work to do there | 12:10 |
| jelkner | when i talked with klarios yesterday about who could help teach me the system, she suggested janet | 12:10 |
| jelkner | which was *wonderful*! | 12:10 |
| jelkner | klarios reported very positively on the work janet has been doing | 12:10 |
| jelkner | so could be a huge help to our project to keep her working | 12:11 |
| jelkner | ACTION done | 12:11 |
| jelkner | questions? | 12:11 |
| gabriel_jetro | -1 | 12:11 |
| thomasboimah | ACTION -1 | 12:11 |
| jelkner | zOnny, to be clear | 12:11 |
| jelkner | i don't think we want to even think about hacking on Decidim yet | 12:12 |
| anthony_p has quit (Remote host closed the connection) | 12:12 | |
| jelkner | that means learning rails | 12:12 |
| jelkner | which will be not hard to do once we *really* understand django | 12:12 |
| jelkner | but is would be *very* confusing to do at the same time! | 12:12 |
| dcammue_ | Sorry for the late join, good day to all | 12:13 |
| zOnny | Yes, jelkner, I get it | 12:13 |
| jelkner | so, django first (for at least the full 6 months we talked about zOnny ) | 12:13 |
| jelkner | and then we evaluate where we are and see if where to go from there | 12:13 |
| jelkner | make sense? | 12:13 |
| gabriel_jetro | +1 | 12:13 |
| zOnny | +1 | 12:14 |
| thomasboimah | +1 | 12:14 |
| jelkner | so that fact that you are working on unit and functional tests is music to my ears!!! ;-) | 12:14 |
| jelkner | thomasboimah, i'll be asking joshua, kara, and ben to learn about that this week | 12:15 |
| thomasboimah | Okay | 12:15 |
| jelkner | they have class tues and thurs this week | 12:15 |
| jelkner | as soon as you all move into your office | 12:16 |
| jelkner | and we setup starlink | 12:16 |
| jelkner | we should set up a jitsi meeting during their class so you can meet them | 12:16 |
| jelkner | ok dcammue_ great to see you! | 12:16 |
| jelkner | dcammue_, if you have time to meet now, let's do that | 12:16 |
| thomasboimah | okay | 12:16 |
| jelkner | we can jump over to #jetrowebdev to leave this channel for the django devs | 12:17 |
| dcammue_ | OK | 12:18 |
| zOnny | alright thanks for the update everyone :) | 12:19 |
| gabriel_jetro | zOnny: and thomasboimah what Todo you guys have for me? | 12:19 |
| gabriel_jetro | I want to be involve | 12:20 |
| zOnny | Hi Gabriel | 12:20 |
| zOnny | Nice to e-meet you | 12:20 |
| gabriel_jetro | Same here, I've been following up, so I think I know a bit about you | 12:20 |
| zOnny | Gabriel have you use Django before? | 12:21 |
| gabriel_jetro | Yes I've on reservation from | 12:22 |
| gabriel_jetro | Form* | 12:22 |
| zOnny | Can you introduce yourself to me and what have you been working on | 12:23 |
| gabriel_jetro | Okay | 12:24 |
| zOnny | Thomas are you here? | 12:25 |
| zOnny | Thomas are you familiar with Django Unit and Funct test? | 12:26 |
| thomasboimah | Sorry i when to the bathroom. +1 | 12:26 |
| zOnny | all good | 12:26 |
| thomasboimah | I have not write unit test before. I have watch video on how to do it | 12:27 |
| thomasboimah | But I'm not sure watching video about it means i know how to do it | 12:28 |
| thomasboimah | WE will see about | 12:28 |
| thomasboimah | it | 12:28 |
| zOnny | We will learn together on this thomas | 12:28 |
| zOnny | I don't remember much neither | 12:28 |
| zOnny | But libre organize have implemented it a lot | 12:29 |
| gabriel_jetro | I'm Gabriel Washington from west Africa Liberia, member of the jetro Web Development, over the years I've been working on many things, I'm a python programmer, few months ago jelkner introduce us to cjones who tasks was to guide us with Django. At first we started a "cosmetology" and " culinary" Django app, my work was to do the reservation from. After a week or more jelkner came up with the idea of doing a Todo which I | 12:29 |
| gabriel_jetro | started on the git lab, but due to my mother's I'll and other circumstances I was inactive recently. | 12:29 |
| zOnny | Awesome gabriel | 12:30 |
| zOnny | and Sorry for your mom | 12:30 |
| zOnny | I hope she is doing well now | 12:30 |
| zOnny | and I wish her a speedy recovery | 12:30 |
| gabriel_jetro | Yes she's | 12:31 |
| gabriel_jetro | Thanks | 12:31 |
| zOnny | gabriel not sure how aware you are with the work Thomas have done | 12:31 |
| gabriel_jetro | I get familiar myself with it | 12:32 |
| zOnny | But if you want to be involve in, It would require to you get familiar with LibreOrganize project | 12:33 |
| zOnny | https://gitlab.com/novawebdevelopment/libreorganize/libreorganize | 12:33 |
| gabriel_jetro | Okay | 12:33 |
| zOnny | I only work weekends here and try to work with thomas to deliver some coming clients requests | 12:34 |
| zOnny | BUt if you have questions or feel stuck feel free to ask | 12:35 |
| zOnny | I will be happy to help | 12:35 |
| thomasboimah | gabriel_jetro, I have a task for you | 12:36 |
| gabriel_jetro | Okay, here's my username | 12:36 |
| gabriel_jetro | @gab-rinho1 | 12:36 |
| thomasboimah | When you done chatting with zOnny | 12:36 |
| gabriel_jetro | Okay | 12:37 |
| gabriel_jetro | zOnny: check I'm familiar with it and that's my username | 12:37 |
| gabriel_jetro | @gab-rinho1 | 12:37 |
| zOnny | Your username in gitlab? | 12:39 |
| gabriel_jetro | Yes | 12:39 |
| zOnny | Thomas feel free to jump in, if you have plans for gabriel | 12:40 |
| zOnny | Thomas are you here? | 12:43 |
| thomasboimah | gabriel_jetro, I want you to write a unit test for the app(tasks) in the todo app project. And also investigate on how to migrate a postgres server to MayFirst and write the information you will find using makerdown for reference, then the two of us can start working on that. Is that okay with you? | 12:44 |
| thomasboimah | +1 zOnny I'm here | 12:45 |
| zOnny | Thomas have you tried to run the LO tests? | 12:46 |
| gabriel_jetro | Sure no problem, when is it deadline? | 12:46 |
| thomasboimah | yes zOnny it python manage.py test right? | 12:46 |
| thomasboimah | but it is loading like ................. | 12:47 |
| zOnny | yes thomas | 12:47 |
| thomasboimah | so I'm giving it some time | 12:47 |
| zOnny | we are using the coverage to run our tests | 12:48 |
| thomasboimah | Anytime you think you can be able to get that done gabriel_jetro | 12:48 |
| zOnny | https://gitlab.com/novawebdevelopment/libreorganize/libreorganize/-/blob/master/requirements.txt?ref_type=heads#L10 | 12:48 |
| gabriel_jetro | I've did unit test before on GitHub https://github.com/gab-rinho1 so I'll try to review from there and see how I'll approch it | 12:49 |
| thomasboimah | The test is complete and i am getting this at the end zOnny : Ran 270 tests in 114.569s | 12:49 |
| thomasboimah | FAILED (failures=2, errors=4) | 12:49 |
| thomasboimah | Destroying test database for alias 'default'... | 12:49 |
| gabriel_jetro | It means 270 tests ran in 114.569 seconds and had two failures with 4 errors | 12:52 |
| thomasboimah | yes gabriel_jetro | 12:52 |
| gabriel_jetro | thomasboimah: I'm in church right now can I go? | 12:55 |
| thomasboimah | sure bro | 12:55 |
| gabriel_jetro | Okay have a nice day, I'll give you updates tomorrow on the stand up meeting | 12:55 |
| zOnny | Thomas run ./tests/automation/run_unit_tests.sh | 12:59 |
| zOnny | Thomas give a 2 min I'm finishing making my cofee | 13:04 |
| thomasboimah | zOnny, this is the 4 error i am observing: test_box_form_uses_ckeditor5_for_english_content - KeyError: 'box' | 13:05 |
| thomasboimah | test_box_form_uses_ckeditor5_for_spanish_content - KeyError: 'box' | 13:05 |
| thomasboimah | test_news_announcement_form_uses_ckeditor5 - KeyError: 'box' | 13:05 |
| thomasboimah | test_wiki_form_uses_ckeditor5 - KeyError: 'box' | 13:05 |
| zOnny | I see | 13:07 |
| zOnny | ckeditor is messing around :) | 13:07 |
| thomasboimah | and these are the two failure: test_incorrect_email - Missing error message in login form | 13:07 |
| thomasboimah | test_calendar_create - Date format mismatch | 13:07 |
| zOnny | Lets focus one app at the time | 13:10 |
| thomasboimah | We have the box in librorganize/app/ | 13:11 |
| anthony_p has quit (Ping timeout: 480 seconds) | 13:12 | |
| thomasboimah | ? | 13:12 |
| zOnny | yes | 13:14 |
| zOnny | Did you see that each app has tests dir | 13:17 |
| thomasboimah | yes | 13:17 |
| zOnny | The most important of these is the test_logic.py | 13:18 |
| jelkner has quit (Quit: Leaving) | 13:19 | |
| zOnny | So let's focus on the blog app | 13:21 |
| zOnny | the way you can run each app test is by python manage.py test apps.blog.tests | 13:24 |
| zOnny | you just change the name of the app | 13:24 |
| thomasboimah | yeah | 13:24 |
| zOnny | can you create the tests directory | 13:25 |
| thomasboimah | okay | 13:25 |
| zOnny | then add the three files | 13:27 |
| zOnny | test_apps.py , test_logic.py, tests_urls.py | 13:28 |
| zOnny | alsodon't forget the __init__.py to get it executed | 13:28 |
| thomasboimah | done | 13:30 |
| zOnny | Let's start with the test_apps.py | 13:31 |
| thomasboimah | We should give it a class name BlogAppsTestCase? | 13:32 |
| zOnny | Yes | 13:32 |
| zOnny | take an example from the other app | 13:32 |
| thomasboimah | sure | 13:32 |
| thomasboimah | most of it will be the classes and import different | 13:33 |
| zOnny | right but do you see what the function is doing | 13:35 |
| thomasboimah | yes I'm also looking at that | 13:35 |
| thomasboimah | Wow! the test_logic.py i need to analyze it | 13:38 |
| zOnny | Test logic is where all the logic goes | 13:39 |
| thomasboimah | yep | 13:39 |
| thomasboimah | the name says it all | 13:39 |
| thomasboimah | *logic* | 13:39 |
| zOnny | This is where you have to Obey the testing GOAT | 13:40 |
| zOnny | https://www.obeythetestinggoat.com/pages/book.html#toc | 13:40 |
| zOnny | Jeff did introduced me to this book | 13:40 |
| thomasboimah | yep ;-) | 13:40 |
| zOnny | So once done the test_apps.py you can run the test and verify it | 13:42 |
| zOnny | ../venv/bin/coverage run manage.py test apps.blog.tests.test_apps | 13:44 |
| thomasboimah | zOnny, can i take a min to log at this test_logic.py | 13:44 |
| thomasboimah | *look* | 13:44 |
| zOnny | yes go ahead | 13:44 |
| zOnny | take the example from the other apps | 13:44 |
| zOnny | If you look at them, most of the logic for the superuser are the same | 13:45 |
| zOnny | The rest is the logic of your views | 13:46 |
| jelkner_ has quit (Remote host closed the connection) | 13:52 | |
| jelkner has quit (Quit: Leaving) | 13:52 | |
| jelkner has quit (Remote host closed the connection) | 13:53 | |
| thomasboimah | ACTION done observing the test_logic.py | 13:56 |
| thomasboimah | done | 13:56 |
| thomasboimah | The blog test_apps give OK | 13:58 |
| zOnny | awesome | 13:58 |
| zOnny | lets start with the urls now before getting into the logic | 13:59 |
| thomasboimah | sure | 13:59 |
| zOnny | Here from django what do you need is the TestCase | 14:00 |
| thomasboimah | request | 14:01 |
| zOnny | https://gitlab.com/novawebdevelopment/libreorganize/libreorganize/-/blob/master/libreorganize/apps/news/tests/test_urls.py?ref_type=heads#L1-2 | 14:04 |
| zOnny | you need those imports from django | 14:05 |
| zOnny | Then you write your first method | 14:06 |
| zOnny | You ca do it as class BlogURLTests(TestCase): | 14:08 |
| zOnny | def test_table_url(self): | 14:11 |
| zOnny | url = reverse("apps.blog:table") | 14:12 |
| zOnny | self.assertEqual(resolve(url).func.view_class, views.TableView) | 14:13 |
| thomasboimah | I did that zOnny: def test_list(self): | 14:13 |
| thomasboimah | """Check list URL correct""" | 14:13 |
| thomasboimah | self.assertEqual(resolve("/blog/list/").view_name, "blog:list") | 14:13 |
| thomasboimah | def test_table(self): | 14:13 |
| thomasboimah | """Check table URL correct""" | 14:13 |
| thomasboimah | self.assertEqual(resolve("/blog/").view_name, "blog:table") | 14:13 |
| thomasboimah | def test_edit(self): | 14:13 |
| thomasboimah | """Check edit URL correct""" | 14:13 |
| thomasboimah | self.assertEqual(resolve("/blog/posts/test-slug/edit/").view_name, "blog:edit") | 14:13 |
| thomasboimah | def test_detail(self): | 14:13 |
| thomasboimah | """Check detail URL correct""" | 14:13 |
| thomasboimah | self.assertEqual(resolve("/blog/posts/test-slug/").view_name, "blog:detail") | 14:13 |
| thomasboimah | def test_create(self): | 14:13 |
| thomasboimah | """Check create URL correct""" | 14:14 |
| thomasboimah | self.assertEqual(resolve("/blog/create/").view_name, "blog:create") | 14:14 |
| thomasboimah | def test_delete(self): | 14:14 |
| thomasboimah | """Check delete URL correct""" | 14:14 |
| thomasboimah | self.assertEqual(resolve("/blog/posts/test-slug/delete/").view_name, "blog:delete") | 14:14 |
| thomasboimah | def test_search(self): | 14:14 |
| thomasboimah | """Check search URL correct""" | 14:14 |
| thomasboimah | self.assertEqual(resolve("/blog/search/").view_name, "blog:search") | 14:14 |
| zOnny | you can use this https://paste.ofcode.org/ | 14:17 |
| zOnny | to make it easier your paste code | 14:17 |
| zOnny | can you try it and sendme the link | 14:18 |
| mulbah has quit (Ping timeout: 480 seconds) | 14:19 | |
| thomasboimah | How can i share it with you | 14:20 |
| thomasboimah | https://paste.ofcode.org/NsuGKXCMUNRiveXx645Lgk | 14:22 |
| zOnny | try to run it | 14:22 |
| zOnny | see if it fails | 14:23 |
| thomasboimah | okay | 14:23 |
| thomasboimah | it give OK | 14:23 |
| thomasboimah | Those are the various urls that is in the blog | 14:24 |
| zOnny | right | 14:25 |
| zOnny | delete the Bulletin | 14:25 |
| zOnny | it is commented out | 14:25 |
| zOnny | we don't need that yes? | 14:25 |
| thomasboimah | +1 | 14:25 |
| zOnny | in the urls.py | 14:25 |
| thomasboimah | The testing is not looking that hard as i though | 14:27 |
| zOnny | can you move the def test_table to the top? | 14:27 |
| thomasboimah | Is just looking like when i am write a python code | 14:28 |
| zOnny | yes, it is similar | 14:28 |
| zOnny | the TestCase interact with the DB | 14:29 |
| zOnny | One think you have to think with the tests is how your app works | 14:30 |
| zOnny | Once you click in the Blog url what is the first thing you see? | 14:30 |
| zOnny | Table, yes? | 14:30 |
| thomasboimah | +1 | 14:31 |
| zOnny | That's how you need to write your test | 14:31 |
| zOnny | you can make more dynamic the urls test | 14:32 |
| zOnny | it seems it is using the absolute path | 14:32 |
| thomasboimah | yep | 14:32 |
| zOnny has quit (Quit: Page closed) | 14:33 | |
| zOnny has quit (None) | 14:34 | |
| zOnny | sda | 14:34 |
| zOnny | Do you see this https://paste.ofcode.org/3a3T3yx6JnZEE4hHfnxG9Yj | 14:36 |
| zOnny | It is another way to approach | 14:36 |
| zOnny | https://paste.ofcode.org/HbLuPGtAi4E6ZMGDjA26Jz | 14:37 |
| thomasboimah | yes | 14:37 |
| zOnny | Here you don't use the absolute path | 14:38 |
| zOnny | It isn't always recommended using the absolute path | 14:38 |
| zOnny | since you are in the future change your url | 14:38 |
| thomasboimah | okay | 14:39 |
| zOnny | Let say you will rename it to blog/table | 14:39 |
| zOnny | In that situation you will also have to change your tests absolute path | 14:40 |
| zOnny | Let's avoid that and make it dynamic | 14:40 |
| thomasboimah | You're right | 14:41 |
| thomasboimah | just a min so that i can change it | 14:43 |
| zOnny | https://paste.ofcode.org/pBUFSmN54QZQmXyZ8drLyd | 14:46 |
| gabriel_jetro has quit (Quit: Connection closed for inactivity) | 15:00 | |
| zOnny | Do you have any questions | 15:07 |
| thomasboimah | -1 I just analyzing how the test_logic is going to be for the blog | 15:08 |
| zOnny | are you done with the urls? | 15:08 |
| thomasboimah | Yeah | 15:09 |
| zOnny | great | 15:09 |
| zOnny | Let's move to the logic now | 15:10 |
| zOnny | First of | 15:14 |
| zOnny | Let's create two different users | 15:14 |
| zOnny | one superuser, and one user | 15:15 |
| zOnny | You can name your first class BlogTestBase(TestCase) | 15:16 |
| zOnny | we are going to use this json | 15:19 |
| zOnny | for our user and superuser | 15:19 |
| zOnny | https://gitlab.com/novawebdevelopment/libreorganize/libreorganize/-/blob/master/libreorganize/tests/test_data/accounts.json?ref_type=heads | 15:19 |
| zOnny | It will saves us lines | 15:20 |
| thomasboimah | we will put it in a variable fixtures right? | 15:27 |
| thomasboimah | That is the variable name i give | 15:28 |
| thomasboimah | zOnny, What about this: core/fixtures/initial_data.json? | 15:32 |
| zOnny | Fixtures initial_data.json we don't need that | 15:37 |
| zOnny | https://paste.ofcode.org/TPVzND7QmYrbFAGMXVajwp | 15:39 |
| zOnny | Are you trying this way? | 15:40 |
| thomasboimah | yes | 15:40 |
| thomasboimah | let me share what i have with you | 15:40 |
| zOnny | Do you understand that code? | 15:40 |
| zOnny | sure | 15:41 |
| thomasboimah | yes, I'm doing it step by step | 15:41 |
| thomasboimah | https://paste.ofcode.org/?edit=pBUFSmN54QZQmXyZ8drLyd | 15:44 |
| thomasboimah | sorry wrong link | 15:45 |
| thomasboimah | https://paste.ofcode.org/3724bLvwBXy8KHvybUJmJcW | 15:45 |
| zOnny | Looks good to me | 15:47 |
| zOnny | It is very explicit :) | 15:47 |
| zOnny | Are you working with the BlogPostFormTests? | 15:52 |
| thomasboimah | +! | 15:56 |
| thomasboimah | wait | 15:56 |
| dcammue_ has quit (Quit: Connection closed for inactivity) | 16:08 | |
| zOnny | How is that going | 16:19 |
| thomasboimah | Now i am trying to write this: def test_public_list_shows_published_only(self):, def test_superuser_sees_all_posts(self):, def test_regular_user_sees_only_published(self): | 16:22 |
| zOnny | Nice | 16:27 |
| zOnny | Seems like you get it | 16:27 |
| thomasboimah | Now this is what i have https://paste.ofcode.org/F8tK4c3DYRdWkgW7drEzXF I will be moving to BlogTableView | 16:27 |
| zOnny | Did you run it | 16:28 |
| thomasboimah | yes | 16:28 |
| thomasboimah | I need to go back to my Python book to refresh myself again on function | 16:29 |
| thomasboimah | after today | 16:29 |
| zOnny | me too | 16:29 |
| zOnny | My backend is really weak at this point | 16:30 |
| thomasboimah | I am taking too long to write function, I use to be fast before | 16:30 |
| thomasboimah | I am taking too long to write function, I use to be fast before | 16:30 |
| zOnny | nice | 16:30 |
| zOnny | use this command to find which lines you are missing | 16:30 |
| zOnny | coverage report --include 'apps/blog/*' | 16:31 |
| zOnny | once you cover the all the logical tests | 16:31 |
| zOnny | coverage will report 100% | 16:31 |
| zOnny | also, I notice that we won't use the Thumbnails | 16:32 |
| zOnny | I did a research about it yesterdayu | 16:33 |
| zOnny | It seems that is an image preview for the post | 16:34 |
| zOnny | I don't think is is a necessity for now | 16:35 |
| zOnny | What are you thoughts about it | 16:35 |
| thomasboimah | yeah, I'm fine skipping them for now. If they're just a nice-to-have preview, we can launch without them and maybe add later if users ask for it. | 16:38 |
| thomasboimah | I mean the thumbnails | 16:38 |
| zOnny | good point | 16:38 |
| zOnny | +1 | 16:38 |
| thomasboimah | I done with the BlogTableView | 16:50 |
| zOnny | Nice | 17:05 |
| zOnny | https://paste.ofcode.org/KkrL7S7AAYrEKKGVrz9d7x | 17:05 |
| zOnny | this is how far I got | 17:05 |
| zOnny | Let's keep it thumbnail | 17:05 |
| zOnny | I will fix it after you push the tests | 17:05 |
| zOnny | I have the feeling that they would like to add an image to their post | 17:06 |
| zOnny | otherwise we will have a default | 17:07 |
| zOnny | Sorry I have indentation on the one above https://paste.ofcode.org/AbPuaMbL8egjuyz8pz4hv6 | 17:13 |
| zOnny | *error* | 17:13 |
| zOnny | Feel free to use if if needed | 17:14 |
| zOnny | Did the coverage report --include 'apps/blog/*' tells you how much have you covered? | 17:19 |
| thomasboimah | yes | 17:20 |
| thomasboimah | apps/blog/__init__.py 0 0 100% | 17:21 |
| thomasboimah | apps/blog/apps.py 3 0 100% | 17:21 |
| thomasboimah | apps/blog/forms.py 39 26 33% | 17:21 |
| thomasboimah | apps/blog/models.py 130 78 40% | 17:21 |
| thomasboimah | apps/blog/urls.py 4 0 100% | 17:21 |
| thomasboimah | apps/blog/views.py 116 59 49% | 17:21 |
| thomasboimah | ------------------------------------------- | 17:21 |
| thomasboimah | TOTAL 292 163 44% | 17:21 |
| zOnny | Cool do you want to finish it today? | 17:22 |
| zOnny | We can call a day if you are going for the 100% | 17:23 |
| zOnny | I can pull it once you finish it | 17:23 |
| thomasboimah | I can work on it during the week a push | 17:23 |
| thomasboimah | *and* | 17:23 |
| thomasboimah | they you can review it | 17:23 |
| zOnny | sounds good to me | 17:24 |
| zOnny | It seems like you are almost 50% | 17:24 |
| thomasboimah | Yeah, little by little | 17:24 |
| zOnny | Send me an email once it is done | 17:24 |
| thomasboimah | When i push it during the week i can send you email | 17:24 |
| thomasboimah | Alright them | 17:25 |
| thomasboimah | we can call it a day | 17:25 |
| zOnny | Do you like coverage library? | 17:25 |
| thomasboimah | +1 | 17:25 |
| thomasboimah | it motivate you | 17:25 |
| zOnny | right | 17:25 |
| zOnny | Well you can use it in your ToDo app as well | 17:26 |
| thomasboimah | definitely | 17:26 |
| zOnny | You are a quick learner Thomas | 17:27 |
| thomasboimah | Thanks | 17:27 |
| zOnny | Alright see you next weekend | 17:28 |
| thomasboimah | Okay thanks for today | 17:28 |
| thomasboimah | I'm learning alot from you | 17:28 |
| zOnny | ACTION sings off for the day | 17:28 |
| zOnny | I'm also learning again | 17:29 |
| zOnny | Its been awhile for me getting back to LO projects | 17:30 |
| zOnny | Also good luck with your UoPeople classes | 17:30 |
| zOnny | or class | 17:30 |
| thomasboimah | Okay thanks | 17:31 |
| zOnny | ACTION signs off for real :) | 17:31 |
| zOnny has quit (Quit: Page closed) | 17:31 | |
| thomasboimah has quit (Quit: Leaving) | 17:31 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!