IRC log of #novawebdev for Tuesday, 2018-03-06

*** mjsir911 has joined #novawebdev00:01
*** mjsir911 has joined #novawebdev07:49
*** mjsir911 has joined #novawebdev08:32
*** mjsir911 has joined #novawebdev08:48
*** mjsir911 has joined #novawebdev09:37
*** replaceafill has joined #novawebdev10:42
*** zOnny has joined #novawebdev11:22
zOnnyHey replaceafill11:32
replaceafillhey zOnny11:32
replaceafillzOnny, do you have time to chat?11:32
zOnnysure, replaceafill11:32
replaceafillzOnny, i've checked your merge request11:32
replaceafillzOnny, and even though i understand what you're trying to do, i don't agree with the way you've done it11:33
replaceafillzOnny, you're mixing two tasks in one11:33
replaceafillzOnny, "cleaning" (which is in fact a refactoring) was not part of the "style edit event forms"11:33
replaceafillzOnny, and because of that approach you've introduced some regressions11:34
replaceafillzOnny, see https://i.imgur.com/rqZES5g.png11:35
replaceafillzOnny, check the "Is Recurring?" and "All Day" fields11:35
replaceafillzOnny, and that's the ****ADD EVENT FORM****11:35
zOnnywhere are the check bars , replaceafill 11:36
replaceafillzOnny, you were not supposed to *change* that11:36
zOnnyWhat you mean with change that , replaceafill11:37
replaceafillzOnny, the add event form was working correctly already11:37
replaceafillzOnny, and you broke it11:37
replaceafillzOnny, that's a regression11:37
zOnnyI broke ir beacause it was not stable at all replaceafill.11:38
zOnny*that11:38
replaceafillzOnny, well, it's still not stable :/11:38
replaceafillzOnny, and at least before i was able to see the checkboxes11:38
zOnnyI can fix that replaceafill 11:39
replaceafillzOnny, i know you can11:39
replaceafillzOnny, but that's not the point11:39
replaceafillzOnny, the point is that you're approach to handling this is not correct11:39
replaceafillzOnny, you need to understand how important is to focus11:39
replaceafillzOnny, and i don't want you to stop innovating11:39
replaceafillzOnny, i fully support the cleaning you want to do11:40
replaceafillzOnny, but you need to guarantee somehow the cleaning doesn't break things11:40
replaceafillzOnny, that's why the cleaning is usually a separate task11:40
replaceafillzOnny, it's what we call refactoring11:40
zOnnyI understand you point replaceafill11:41
replaceafillzOnny, cool11:42
replaceafillzOnny, and please stop doing this:11:43
replaceafillzOnny, <!--<link rel="stylesheet" href="{{ THEME_URL }}css/global.css">-->11:43
replaceafillzOnny, i think i told you already about this11:43
replaceafillzOnny, don't comment code out11:43
replaceafillzOnny, just delete the whole thing11:43
zOnnyups I forgot that , replaceafill11:43
replaceafillzOnny, :/11:43
*** mr_german has joined #novawebdev11:44
zOnnyabout break thinks, replaceafill 11:45
zOnny*things11:45
zOnnyI was thinking In a way to keep it simpler, replaceafill11:46
replaceafillzOnny, i understand11:46
replaceafillzOnny, i really do11:46
replaceafillzOnny, again11:46
replaceafillzOnny, i'm not against that11:47
replaceafillzOnny, and i'm happy you're thinking about it11:47
replaceafillzOnny, just do it as a separate task11:47
replaceafillzOnny, like "let's simplify this code"11:47
replaceafillzOnny, "but first lets make sure how the app works"11:47
replaceafillzOnny, "and that after our simplification the app still works the same"11:48
replaceafillzOnny, have you heard about refactoring?11:48
zOnnywhat is that ? replaceafill11:48
replaceafillzOnny, ask jelkner :)11:48
replaceafillzOnny, he will explain better and faster :D11:48
zOnny:(11:48
replaceafillzOnny, i mean, this is IRC chat ;)11:49
replaceafillzOnny, https://en.wikipedia.org/wiki/Code_refactoring11:49
replaceafillzOnny, "Code refactoring is the process of restructuring existing computer code—changing the factoring—without changing its external behavior"11:49
replaceafillzOnny, note the last part11:49
zOnnyI know having this new style css, will break the dashboard and the memberships form repalcaefill11:49
replaceafillzOnny, "withouth changing behavior"11:49
replaceafillzOnny, correct11:50
zOnnybut I just can add them to this.11:50
zOnnythere is not need for more lines11:50
replaceafillzOnny, that's why you can't do it in the same step as "style edit event form"11:50
replaceafillzOnny, i know!!!!11:50
zOnnyAs I did in nea4org11:50
replaceafillzOnny, :)11:50
replaceafillzOnny, i'm not questioning your ability to do so11:51
zOnnycan I work on that ? replaceafill11:52
replaceafillzOnny, this is like trying to style events, forums, settings, users, groups, mailing lists in a single commit11:52
replaceafillzOnny, you don't do that11:52
replaceafillzOnny, you break the styling work in separate manageable tasks11:52
replaceafillzOnny, do you understand that point?11:53
replaceafillzOnny, we've asked you to "style the edit event form"11:53
replaceafillzOnny, just make it similar to the "add event form", trying to reuse existing code ***IN MASTER***11:53
replaceafillzOnny, once that's done, you can do your cleaning/simplifying11:54
replaceafillzOnny, oh btw11:56
replaceafillzOnny, @supports (display: grid) or (display:content) {11:56
replaceafillzOnny, do you really understand the purpose of that part?11:56
zOnnyabout that feature query ? so far yes. repalcaefill11:57
zOnny*replaceafill11:57
replaceafillzOnny, sure it's a feature query, but why are you using it with rules like:11:58
replaceafill{11:58
replaceafill     max-width: 90%;11:58
replaceafill     margin-left: auto;11:58
replaceafill     margin-right: auto;11:58
replaceafill }11:58
replaceafillzOnny, ?11:58
replaceafillzOnny, and what's the alternative when the query fails?11:59
zOnnybecause it has a wapper column as a parent replaceafill11:59
replaceafillzOnny, and as far as i know "content" is not a valid value for display, is it?11:59
zOnnyhttps://caniuse.com/#feat=css-display-contents12:04
replaceafillzOnny, yep12:04
replaceafillzOnny, content"s"12:04
zOnnyups :(12:04
replaceafillsigh...12:05
replaceafillzOnny, just commented on the merge request12:05
replaceafillzOnny, ok, that's all i had to say12:06
replaceafillzOnny, if you're curious, this is the reason checkboxes are not displaying for me: https://i.imgur.com/ISbJBM4.png12:08
zOnnyI finish it late night , I did not make double check replaceafill12:08
zOnny*finished12:09
replaceafillzOnny, that's what we're doing right now ;)12:09
replaceafillzOnny, since we don't have automated testing we need to rely on functional reviews from other people12:10
replaceafillzOnny, oh and i forgot one thing i wanted to say12:10
replaceafillzOnny, since you'll be making progress on the nea4or theme12:11
replaceafillzOnny, and probably improving things12:11
replaceafillzOnny, think about how to integrate those into the ORA theme too12:12
replaceafillzOnny, in an ideal world we would have our own "base theme"12:12
zOnnyThat was that I was trying to make with the css 12:13
replaceafillzOnny, i know12:13
replaceafillzOnny, and you will get there, you'll see12:13
zOnnyeven we can have both working with the same css 12:13
replaceafillzOnny, that's the base theme idea, yes12:14
replaceafillzOnny, shared code for all our tendenci themes12:14
zOnnybut you said that I need to keep as the events /add has right now12:14
replaceafillzOnny, yes12:14
replaceafillzOnny, notice the "right now" part12:14
zOnnyWhy not change that early than late12:15
replaceafillzOnny, because it happens what i just showed you, regressions12:15
replaceafillzOnny, and in production we're relying that things work12:15
replaceafillzOnny, it's the eternal dilemma about production vs development12:16
replaceafillzOnny, you need to be really careful with production12:16
replaceafillzOnny, it's one of those things old people say to young people :S12:16
replaceafillzOnny, i remember when i used to feel frustated that we were going too slow because of our manager :D12:17
replaceafillok, enough talking, i should go back to deploying this stuff...12:18
zOnnycan we hang out today ? replaceafill12:18
replaceafillzOnny, 4 pm?12:19
zOnnysounds good, see u then replaceafill12:19
replaceafillzOnny, later!12:19
replaceafillzOnny, for reference: https://martinfowler.com/articles/workflowsOfRefactoring/#2hats12:29
replaceafillzOnny, you should check that presentation if you have a chance12:29
replaceafillzOnny, https://www.youtube.com/watch?v=vqEg37e4Mkw12:29
*** mjsir911 has joined #novawebdev13:19
*** zOnny has joined #novawebdev13:35
*** mjsir911 has joined #novawebdev13:58
*** mjsir911 has joined #novawebdev14:17
*** zOnny has joined #novawebdev15:21
zOnnyhey replaceafill15:22
replaceafillhey zOnny15:35
zOnnyreplaceafill, I will leave at 4:00 from jeff's classroom15:36
replaceafillzOnny, ok15:37
zOnnyreplaceafill, I just want to make a quick hang out to clarify what I should be doing right now.15:38
replaceafillzOnny, i can't talk at the moment, but i can chat15:39
replaceafillzOnny, are you going to work on the edit event forms?15:39
zOnnyreplaceafill I understand15:39
replaceafillzOnny, we just need to fix the things you reported on https://gitlab.com/novawebdevelopment/tendenci-theme-ora/issues/815:40
replaceafillzOnny, makes sense?15:41
zOnnyuuhhmmmm , well, if that is what you want , I will. replaceafill15:42
replaceafillzOnny, yes that's what we need at this point15:42
replaceafillzOnny, i'd also appreciate if you could address this comment: https://gitlab.com/novawebdevelopment/tendenci-theme-ora/merge_requests/7#note_6176633815:43
replaceafillbrb15:45
*** mjsir911 has joined #novawebdev15:45
*** louisea has joined #novawebdev17:02
*** replaceafill has joined #novawebdev17:45
*** zOnny has joined #novawebdev19:33
*** mjsir911 has joined #novawebdev20:34

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!