| *** mjsir911 has joined #novawebdev | 00:01 | |
| *** mjsir911 has joined #novawebdev | 07:49 | |
| *** mjsir911 has joined #novawebdev | 08:32 | |
| *** mjsir911 has joined #novawebdev | 08:48 | |
| *** mjsir911 has joined #novawebdev | 09:37 | |
| *** replaceafill has joined #novawebdev | 10:42 | |
| *** zOnny has joined #novawebdev | 11:22 | |
| zOnny | Hey replaceafill | 11:32 |
|---|---|---|
| replaceafill | hey zOnny | 11:32 |
| replaceafill | zOnny, do you have time to chat? | 11:32 |
| zOnny | sure, replaceafill | 11:32 |
| replaceafill | zOnny, i've checked your merge request | 11:32 |
| replaceafill | zOnny, and even though i understand what you're trying to do, i don't agree with the way you've done it | 11:33 |
| replaceafill | zOnny, you're mixing two tasks in one | 11:33 |
| replaceafill | zOnny, "cleaning" (which is in fact a refactoring) was not part of the "style edit event forms" | 11:33 |
| replaceafill | zOnny, and because of that approach you've introduced some regressions | 11:34 |
| replaceafill | zOnny, see https://i.imgur.com/rqZES5g.png | 11:35 |
| replaceafill | zOnny, check the "Is Recurring?" and "All Day" fields | 11:35 |
| replaceafill | zOnny, and that's the ****ADD EVENT FORM**** | 11:35 |
| zOnny | where are the check bars , replaceafill | 11:36 |
| replaceafill | zOnny, you were not supposed to *change* that | 11:36 |
| zOnny | What you mean with change that , replaceafill | 11:37 |
| replaceafill | zOnny, the add event form was working correctly already | 11:37 |
| replaceafill | zOnny, and you broke it | 11:37 |
| replaceafill | zOnny, that's a regression | 11:37 |
| zOnny | I broke ir beacause it was not stable at all replaceafill. | 11:38 |
| zOnny | *that | 11:38 |
| replaceafill | zOnny, well, it's still not stable :/ | 11:38 |
| replaceafill | zOnny, and at least before i was able to see the checkboxes | 11:38 |
| zOnny | I can fix that replaceafill | 11:39 |
| replaceafill | zOnny, i know you can | 11:39 |
| replaceafill | zOnny, but that's not the point | 11:39 |
| replaceafill | zOnny, the point is that you're approach to handling this is not correct | 11:39 |
| replaceafill | zOnny, you need to understand how important is to focus | 11:39 |
| replaceafill | zOnny, and i don't want you to stop innovating | 11:39 |
| replaceafill | zOnny, i fully support the cleaning you want to do | 11:40 |
| replaceafill | zOnny, but you need to guarantee somehow the cleaning doesn't break things | 11:40 |
| replaceafill | zOnny, that's why the cleaning is usually a separate task | 11:40 |
| replaceafill | zOnny, it's what we call refactoring | 11:40 |
| zOnny | I understand you point replaceafill | 11:41 |
| replaceafill | zOnny, cool | 11:42 |
| replaceafill | zOnny, and please stop doing this: | 11:43 |
| replaceafill | zOnny, <!--<link rel="stylesheet" href="{{ THEME_URL }}css/global.css">--> | 11:43 |
| replaceafill | zOnny, i think i told you already about this | 11:43 |
| replaceafill | zOnny, don't comment code out | 11:43 |
| replaceafill | zOnny, just delete the whole thing | 11:43 |
| zOnny | ups I forgot that , replaceafill | 11:43 |
| replaceafill | zOnny, :/ | 11:43 |
| *** mr_german has joined #novawebdev | 11:44 | |
| zOnny | about break thinks, replaceafill | 11:45 |
| zOnny | *things | 11:45 |
| zOnny | I was thinking In a way to keep it simpler, replaceafill | 11:46 |
| replaceafill | zOnny, i understand | 11:46 |
| replaceafill | zOnny, i really do | 11:46 |
| replaceafill | zOnny, again | 11:46 |
| replaceafill | zOnny, i'm not against that | 11:47 |
| replaceafill | zOnny, and i'm happy you're thinking about it | 11:47 |
| replaceafill | zOnny, just do it as a separate task | 11:47 |
| replaceafill | zOnny, like "let's simplify this code" | 11:47 |
| replaceafill | zOnny, "but first lets make sure how the app works" | 11:47 |
| replaceafill | zOnny, "and that after our simplification the app still works the same" | 11:48 |
| replaceafill | zOnny, have you heard about refactoring? | 11:48 |
| zOnny | what is that ? replaceafill | 11:48 |
| replaceafill | zOnny, ask jelkner :) | 11:48 |
| replaceafill | zOnny, he will explain better and faster :D | 11:48 |
| zOnny | :( | 11:48 |
| replaceafill | zOnny, i mean, this is IRC chat ;) | 11:49 |
| replaceafill | zOnny, https://en.wikipedia.org/wiki/Code_refactoring | 11:49 |
| replaceafill | zOnny, "Code refactoring is the process of restructuring existing computer code—changing the factoring—without changing its external behavior" | 11:49 |
| replaceafill | zOnny, note the last part | 11:49 |
| zOnny | I know having this new style css, will break the dashboard and the memberships form repalcaefill | 11:49 |
| replaceafill | zOnny, "withouth changing behavior" | 11:49 |
| replaceafill | zOnny, correct | 11:50 |
| zOnny | but I just can add them to this. | 11:50 |
| zOnny | there is not need for more lines | 11:50 |
| replaceafill | zOnny, that's why you can't do it in the same step as "style edit event form" | 11:50 |
| replaceafill | zOnny, i know!!!! | 11:50 |
| zOnny | As I did in nea4org | 11:50 |
| replaceafill | zOnny, :) | 11:50 |
| replaceafill | zOnny, i'm not questioning your ability to do so | 11:51 |
| zOnny | can I work on that ? replaceafill | 11:52 |
| replaceafill | zOnny, this is like trying to style events, forums, settings, users, groups, mailing lists in a single commit | 11:52 |
| replaceafill | zOnny, you don't do that | 11:52 |
| replaceafill | zOnny, you break the styling work in separate manageable tasks | 11:52 |
| replaceafill | zOnny, do you understand that point? | 11:53 |
| replaceafill | zOnny, we've asked you to "style the edit event form" | 11:53 |
| replaceafill | zOnny, just make it similar to the "add event form", trying to reuse existing code ***IN MASTER*** | 11:53 |
| replaceafill | zOnny, once that's done, you can do your cleaning/simplifying | 11:54 |
| replaceafill | zOnny, oh btw | 11:56 |
| replaceafill | zOnny, @supports (display: grid) or (display:content) { | 11:56 |
| replaceafill | zOnny, do you really understand the purpose of that part? | 11:56 |
| zOnny | about that feature query ? so far yes. repalcaefill | 11:57 |
| zOnny | *replaceafill | 11:57 |
| replaceafill | zOnny, sure it's a feature query, but why are you using it with rules like: | 11:58 |
| replaceafill | { | 11:58 |
| replaceafill | max-width: 90%; | 11:58 |
| replaceafill | margin-left: auto; | 11:58 |
| replaceafill | margin-right: auto; | 11:58 |
| replaceafill | } | 11:58 |
| replaceafill | zOnny, ? | 11:58 |
| replaceafill | zOnny, and what's the alternative when the query fails? | 11:59 |
| zOnny | because it has a wapper column as a parent replaceafill | 11:59 |
| replaceafill | zOnny, and as far as i know "content" is not a valid value for display, is it? | 11:59 |
| zOnny | https://caniuse.com/#feat=css-display-contents | 12:04 |
| replaceafill | zOnny, yep | 12:04 |
| replaceafill | zOnny, content"s" | 12:04 |
| zOnny | ups :( | 12:04 |
| replaceafill | sigh... | 12:05 |
| replaceafill | zOnny, just commented on the merge request | 12:05 |
| replaceafill | zOnny, ok, that's all i had to say | 12:06 |
| replaceafill | zOnny, if you're curious, this is the reason checkboxes are not displaying for me: https://i.imgur.com/ISbJBM4.png | 12:08 |
| zOnny | I finish it late night , I did not make double check replaceafill | 12:08 |
| zOnny | *finished | 12:09 |
| replaceafill | zOnny, that's what we're doing right now ;) | 12:09 |
| replaceafill | zOnny, since we don't have automated testing we need to rely on functional reviews from other people | 12:10 |
| replaceafill | zOnny, oh and i forgot one thing i wanted to say | 12:10 |
| replaceafill | zOnny, since you'll be making progress on the nea4or theme | 12:11 |
| replaceafill | zOnny, and probably improving things | 12:11 |
| replaceafill | zOnny, think about how to integrate those into the ORA theme too | 12:12 |
| replaceafill | zOnny, in an ideal world we would have our own "base theme" | 12:12 |
| zOnny | That was that I was trying to make with the css | 12:13 |
| replaceafill | zOnny, i know | 12:13 |
| replaceafill | zOnny, and you will get there, you'll see | 12:13 |
| zOnny | even we can have both working with the same css | 12:13 |
| replaceafill | zOnny, that's the base theme idea, yes | 12:14 |
| replaceafill | zOnny, shared code for all our tendenci themes | 12:14 |
| zOnny | but you said that I need to keep as the events /add has right now | 12:14 |
| replaceafill | zOnny, yes | 12:14 |
| replaceafill | zOnny, notice the "right now" part | 12:14 |
| zOnny | Why not change that early than late | 12:15 |
| replaceafill | zOnny, because it happens what i just showed you, regressions | 12:15 |
| replaceafill | zOnny, and in production we're relying that things work | 12:15 |
| replaceafill | zOnny, it's the eternal dilemma about production vs development | 12:16 |
| replaceafill | zOnny, you need to be really careful with production | 12:16 |
| replaceafill | zOnny, it's one of those things old people say to young people :S | 12:16 |
| replaceafill | zOnny, i remember when i used to feel frustated that we were going too slow because of our manager :D | 12:17 |
| replaceafill | ok, enough talking, i should go back to deploying this stuff... | 12:18 |
| zOnny | can we hang out today ? replaceafill | 12:18 |
| replaceafill | zOnny, 4 pm? | 12:19 |
| zOnny | sounds good, see u then replaceafill | 12:19 |
| replaceafill | zOnny, later! | 12:19 |
| replaceafill | zOnny, for reference: https://martinfowler.com/articles/workflowsOfRefactoring/#2hats | 12:29 |
| replaceafill | zOnny, you should check that presentation if you have a chance | 12:29 |
| replaceafill | zOnny, https://www.youtube.com/watch?v=vqEg37e4Mkw | 12:29 |
| *** mjsir911 has joined #novawebdev | 13:19 | |
| *** zOnny has joined #novawebdev | 13:35 | |
| *** mjsir911 has joined #novawebdev | 13:58 | |
| *** mjsir911 has joined #novawebdev | 14:17 | |
| *** zOnny has joined #novawebdev | 15:21 | |
| zOnny | hey replaceafill | 15:22 |
| replaceafill | hey zOnny | 15:35 |
| zOnny | replaceafill, I will leave at 4:00 from jeff's classroom | 15:36 |
| replaceafill | zOnny, ok | 15:37 |
| zOnny | replaceafill, I just want to make a quick hang out to clarify what I should be doing right now. | 15:38 |
| replaceafill | zOnny, i can't talk at the moment, but i can chat | 15:39 |
| replaceafill | zOnny, are you going to work on the edit event forms? | 15:39 |
| zOnny | replaceafill I understand | 15:39 |
| replaceafill | zOnny, we just need to fix the things you reported on https://gitlab.com/novawebdevelopment/tendenci-theme-ora/issues/8 | 15:40 |
| replaceafill | zOnny, makes sense? | 15:41 |
| zOnny | uuhhmmmm , well, if that is what you want , I will. replaceafill | 15:42 |
| replaceafill | zOnny, yes that's what we need at this point | 15:42 |
| replaceafill | zOnny, i'd also appreciate if you could address this comment: https://gitlab.com/novawebdevelopment/tendenci-theme-ora/merge_requests/7#note_61766338 | 15:43 |
| replaceafill | brb | 15:45 |
| *** mjsir911 has joined #novawebdev | 15:45 | |
| *** louisea has joined #novawebdev | 17:02 | |
| *** replaceafill has joined #novawebdev | 17:45 | |
| *** zOnny has joined #novawebdev | 19:33 | |
| *** mjsir911 has joined #novawebdev | 20:34 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
