IRC log of #novawebdev for Tuesday, 2018-09-25

*** mjsir911 has joined #novawebdev08:54
*** lelkneralfaro has joined #novawebdev09:36
*** mjsir911 has joined #novawebdev10:52
*** replaceafill has joined #novawebdev11:26
*** mr_german has joined #novawebdev12:03
*** mjsir911 has joined #novawebdev12:22
*** replaceafill has joined #novawebdev13:20
*** lelkneralfaro has joined #novawebdev13:49
*** GFbot has joined #novawebdev14:36
replaceafillACTION goes to get lunch, bb in ~1h14:46
*** mjsir911 has joined #novawebdev16:03
GFbotreplaceafill, https://github.com/gfbot/tendenci/tree/gfbot/slug_groups_fixed16:14
replaceafillACTION is back16:18
replaceafillGFbot, great16:19
replaceafillGFbot, i see an issue with your approach though16:21
replaceafillGFbot, you've fixed it at the model level16:21
GFbotreplaceafill, it works?16:22
replaceafillGFbot, i don't know, but i wonder two things:16:23
GFbotmm16:23
GFbot?16:23
replaceafillGFbot, does this need a migration for existing databases16:23
GFbotnop16:23
replaceafillGFbot, tendenci already uses this approach in the slug field16:23
replaceafillGFbot, https://github.com/tendenci/tendenci/blob/tendenci7/tendenci/apps/base/forms.py#L54-L7616:24
replaceafillGFbot, that ^ works at the form level16:25
replaceafillGFbot, which is the way i expected you to fix this16:25
GFbotreplaceafill, so should i do it in that way?16:26
replaceafillGFbot, https://demo.tendenci.com/admin/videos/video/add/16:28
replaceafillGFbot, check the validation in that slug field16:29
GFbotyeah16:29
GFboti see16:29
replaceafillGFbot, oh16:30
replaceafillGFbot, the slugfield in the video model is from django16:30
replaceafillGFbot, and the slugfield in the group is from tendenci!16:30
GFbotreplaceafill, wtf16:30
GFbotdouble16:30
GFbotslugfield16:30
GFbot?16:31
GFboti'm kind of confused with that replaceafill 16:32
GFbotlol16:32
replaceafillGFbot, hold on16:32
GFbotwhich of them should i use then16:32
GFbotreplaceafill, ok16:33
replaceafillGFbot, django 1.8: https://github.com/django/django/blob/stable/1.8.x/django/db/models/fields/__init__.py#L2115-L211616:33
replaceafillGFbot, tendenci's *model* slugfield: https://github.com/tendenci/tendenci/blob/tendenci7/tendenci/apps/base/fields.py#L23-L4216:34
replaceafillGFbot, no validation16:34
GFbotoh16:35
GFbotit uses form16:35
replaceafillGFbot, yes, the *form* has the validator16:37
replaceafillGFbot, in tendenci16:37
replaceafill716:37
replaceafillGFbot, the *form field*16:37
replaceafillGFbot, and read the last paragraph here: https://docs.djangoproject.com/en/1.8/ref/validators/#writing-validators16:38
replaceafillGFbot, that's my only concern16:39
replaceafillGFbot, how do you know including new validators in the field doesn't require a migration change?16:39
GFbotit doees16:47
GFbotit says16:47
GFboton terminal16:47
replaceafillGFbot, hm?16:47
replaceafillGFbot, explain better16:48
replaceafillGFbot, what do you mean?16:48
GFboton terminal it says "migrate"16:48
GFbotnow16:48
replaceafillGFbot, so it needs the migration?16:48
GFbotit needs but, it works without it16:49
replaceafillGFbot, that's not the point16:52
replaceafillGFbot, changing the model field implies the migration16:53
replaceafillGFbot, so your patch is incomplete16:53
GFbotso16:53
GFbotit should be16:53
GFbotform.py16:53
replaceafillGFbot, because you'd need make migrations on the group package16:53
replaceafillGFbot, how confortable would you be talking with tendenci.com directly about this?16:54
GFbotmm16:54
replaceafillGFbot, since you're trying to patch their repo, they should be the ones deciding16:55
replaceafillGFbot, they do have an error there16:55
GFbotit is possible to fix it16:56
GFbotwithout migrate16:56
GFbot?16:56
replaceafillGFbot, yes, same change at the form level16:59
replaceafillGFbot, by same change i mean, the *form field* needs to use the validator16:59
GFbotreplaceafill, let me see what i can do16:59
GFbotreplaceafill, btw. i was reading about validator yesterday17:00
replaceafillGFbot, my fear is that you're wasting time on this17:00
replaceafillGFbot, it's like it takes you too long to get here17:00
replaceafillGFbot, i understand this is new to you17:00
replaceafillGFbot, but i don't want you 1) hitting walls and not asking and 2) leaving this unattended for too long17:01
replaceafillGFbot, maybe we should ask jelkner and zOnny for feedback on what you should be doing17:01
replaceafillGFbot, take this issue to the tendenci.com issue tracker by tomorrow17:03
replaceafillGFbot, and let them advice on a good approach17:03
replaceafillGFbot, once you repot this issue, work on this: https://gitlab.com/novawebdevelopment/novawebdev-ams/issues/4417:05
replaceafillGFbot, it's a bit similar17:05
GFbotreplaceafill, cool17:07
GFbotreplaceafill, so.. i have to make a pull request to tendenci17:07
GFbot?17:07
replaceafillGFbot, yes17:07
GFbotok17:07
replaceafillGFbot, it's you and them from now17:07
replaceafillGFbot, i won't be checking any of your work on this17:08
replaceafillGFbot, they can17:08
replaceafillGFbot, take us home :)17:08
GFbotreplaceafill, :( ok17:09
replaceafillGFbot, and don't worry if they don't pay attention at first17:11
replaceafillGFbot, see https://github.com/benadida/helios-server/pull/205 for example17:11
replaceafillGFbot, it's been there for more than a month17:11
GFbotreplaceafill, i was with you17:12
GFbotwhen you made it17:12
GFbotcreated*17:12
replaceafillGFbot, ah17:12
replaceafillGFbot, so i'd recommend you report the issue as an issue first17:13
replaceafillGFbot, and ask there for your change17:13
replaceafillGFbot, i mean, your proposed fix17:13
replaceafillGFbot, saying that you're not sure if it's the best approach17:13
replaceafillGFbot, and you're willing to fix it17:13
replaceafillGFbot, provide clear steps from the demo how to reproduce the issue17:13
replaceafillGFbot, ok?17:13
GFbotreplaceafill, yes, i need to think17:14
replaceafillGFbot, and explain what do you think it causes it17:14
replaceafillGFbot, cool17:14
replaceafillGFbot, once you do that, move to the helios slug bug17:14
replaceafillGFbot, ok?17:14
GFbotk17:14
replaceafillGFbot, cool, thanks17:15
replaceafillACTION returns to gallaudet work17:15
GFbotACTION goes to pick his brother17:48
*** mjsir911 has joined #novawebdev19:05
*** mjsir911 has joined #novawebdev20:17
*** mjsir911 has joined #novawebdev20:34

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!