| *** mjsir911 has joined #novawebdev | 08:54 | |
| *** lelkneralfaro has joined #novawebdev | 09:36 | |
| *** mjsir911 has joined #novawebdev | 10:52 | |
| *** replaceafill has joined #novawebdev | 11:26 | |
| *** mr_german has joined #novawebdev | 12:03 | |
| *** mjsir911 has joined #novawebdev | 12:22 | |
| *** replaceafill has joined #novawebdev | 13:20 | |
| *** lelkneralfaro has joined #novawebdev | 13:49 | |
| *** GFbot has joined #novawebdev | 14:36 | |
| replaceafill | ACTION goes to get lunch, bb in ~1h | 14:46 |
|---|---|---|
| *** mjsir911 has joined #novawebdev | 16:03 | |
| GFbot | replaceafill, https://github.com/gfbot/tendenci/tree/gfbot/slug_groups_fixed | 16:14 |
| replaceafill | ACTION is back | 16:18 |
| replaceafill | GFbot, great | 16:19 |
| replaceafill | GFbot, i see an issue with your approach though | 16:21 |
| replaceafill | GFbot, you've fixed it at the model level | 16:21 |
| GFbot | replaceafill, it works? | 16:22 |
| replaceafill | GFbot, i don't know, but i wonder two things: | 16:23 |
| GFbot | mm | 16:23 |
| GFbot | ? | 16:23 |
| replaceafill | GFbot, does this need a migration for existing databases | 16:23 |
| GFbot | nop | 16:23 |
| replaceafill | GFbot, tendenci already uses this approach in the slug field | 16:23 |
| replaceafill | GFbot, https://github.com/tendenci/tendenci/blob/tendenci7/tendenci/apps/base/forms.py#L54-L76 | 16:24 |
| replaceafill | GFbot, that ^ works at the form level | 16:25 |
| replaceafill | GFbot, which is the way i expected you to fix this | 16:25 |
| GFbot | replaceafill, so should i do it in that way? | 16:26 |
| replaceafill | GFbot, https://demo.tendenci.com/admin/videos/video/add/ | 16:28 |
| replaceafill | GFbot, check the validation in that slug field | 16:29 |
| GFbot | yeah | 16:29 |
| GFbot | i see | 16:29 |
| replaceafill | GFbot, oh | 16:30 |
| replaceafill | GFbot, the slugfield in the video model is from django | 16:30 |
| replaceafill | GFbot, and the slugfield in the group is from tendenci! | 16:30 |
| GFbot | replaceafill, wtf | 16:30 |
| GFbot | double | 16:30 |
| GFbot | slugfield | 16:30 |
| GFbot | ? | 16:31 |
| GFbot | i'm kind of confused with that replaceafill | 16:32 |
| GFbot | lol | 16:32 |
| replaceafill | GFbot, hold on | 16:32 |
| GFbot | which of them should i use then | 16:32 |
| GFbot | replaceafill, ok | 16:33 |
| replaceafill | GFbot, django 1.8: https://github.com/django/django/blob/stable/1.8.x/django/db/models/fields/__init__.py#L2115-L2116 | 16:33 |
| replaceafill | GFbot, tendenci's *model* slugfield: https://github.com/tendenci/tendenci/blob/tendenci7/tendenci/apps/base/fields.py#L23-L42 | 16:34 |
| replaceafill | GFbot, no validation | 16:34 |
| GFbot | oh | 16:35 |
| GFbot | it uses form | 16:35 |
| replaceafill | GFbot, yes, the *form* has the validator | 16:37 |
| replaceafill | GFbot, in tendenci | 16:37 |
| replaceafill | 7 | 16:37 |
| replaceafill | GFbot, the *form field* | 16:37 |
| replaceafill | GFbot, and read the last paragraph here: https://docs.djangoproject.com/en/1.8/ref/validators/#writing-validators | 16:38 |
| replaceafill | GFbot, that's my only concern | 16:39 |
| replaceafill | GFbot, how do you know including new validators in the field doesn't require a migration change? | 16:39 |
| GFbot | it doees | 16:47 |
| GFbot | it says | 16:47 |
| GFbot | on terminal | 16:47 |
| replaceafill | GFbot, hm? | 16:47 |
| replaceafill | GFbot, explain better | 16:48 |
| replaceafill | GFbot, what do you mean? | 16:48 |
| GFbot | on terminal it says "migrate" | 16:48 |
| GFbot | now | 16:48 |
| replaceafill | GFbot, so it needs the migration? | 16:48 |
| GFbot | it needs but, it works without it | 16:49 |
| replaceafill | GFbot, that's not the point | 16:52 |
| replaceafill | GFbot, changing the model field implies the migration | 16:53 |
| replaceafill | GFbot, so your patch is incomplete | 16:53 |
| GFbot | so | 16:53 |
| GFbot | it should be | 16:53 |
| GFbot | form.py | 16:53 |
| replaceafill | GFbot, because you'd need make migrations on the group package | 16:53 |
| replaceafill | GFbot, how confortable would you be talking with tendenci.com directly about this? | 16:54 |
| GFbot | mm | 16:54 |
| replaceafill | GFbot, since you're trying to patch their repo, they should be the ones deciding | 16:55 |
| replaceafill | GFbot, they do have an error there | 16:55 |
| GFbot | it is possible to fix it | 16:56 |
| GFbot | without migrate | 16:56 |
| GFbot | ? | 16:56 |
| replaceafill | GFbot, yes, same change at the form level | 16:59 |
| replaceafill | GFbot, by same change i mean, the *form field* needs to use the validator | 16:59 |
| GFbot | replaceafill, let me see what i can do | 16:59 |
| GFbot | replaceafill, btw. i was reading about validator yesterday | 17:00 |
| replaceafill | GFbot, my fear is that you're wasting time on this | 17:00 |
| replaceafill | GFbot, it's like it takes you too long to get here | 17:00 |
| replaceafill | GFbot, i understand this is new to you | 17:00 |
| replaceafill | GFbot, but i don't want you 1) hitting walls and not asking and 2) leaving this unattended for too long | 17:01 |
| replaceafill | GFbot, maybe we should ask jelkner and zOnny for feedback on what you should be doing | 17:01 |
| replaceafill | GFbot, take this issue to the tendenci.com issue tracker by tomorrow | 17:03 |
| replaceafill | GFbot, and let them advice on a good approach | 17:03 |
| replaceafill | GFbot, once you repot this issue, work on this: https://gitlab.com/novawebdevelopment/novawebdev-ams/issues/44 | 17:05 |
| replaceafill | GFbot, it's a bit similar | 17:05 |
| GFbot | replaceafill, cool | 17:07 |
| GFbot | replaceafill, so.. i have to make a pull request to tendenci | 17:07 |
| GFbot | ? | 17:07 |
| replaceafill | GFbot, yes | 17:07 |
| GFbot | ok | 17:07 |
| replaceafill | GFbot, it's you and them from now | 17:07 |
| replaceafill | GFbot, i won't be checking any of your work on this | 17:08 |
| replaceafill | GFbot, they can | 17:08 |
| replaceafill | GFbot, take us home :) | 17:08 |
| GFbot | replaceafill, :( ok | 17:09 |
| replaceafill | GFbot, and don't worry if they don't pay attention at first | 17:11 |
| replaceafill | GFbot, see https://github.com/benadida/helios-server/pull/205 for example | 17:11 |
| replaceafill | GFbot, it's been there for more than a month | 17:11 |
| GFbot | replaceafill, i was with you | 17:12 |
| GFbot | when you made it | 17:12 |
| GFbot | created* | 17:12 |
| replaceafill | GFbot, ah | 17:12 |
| replaceafill | GFbot, so i'd recommend you report the issue as an issue first | 17:13 |
| replaceafill | GFbot, and ask there for your change | 17:13 |
| replaceafill | GFbot, i mean, your proposed fix | 17:13 |
| replaceafill | GFbot, saying that you're not sure if it's the best approach | 17:13 |
| replaceafill | GFbot, and you're willing to fix it | 17:13 |
| replaceafill | GFbot, provide clear steps from the demo how to reproduce the issue | 17:13 |
| replaceafill | GFbot, ok? | 17:13 |
| GFbot | replaceafill, yes, i need to think | 17:14 |
| replaceafill | GFbot, and explain what do you think it causes it | 17:14 |
| replaceafill | GFbot, cool | 17:14 |
| replaceafill | GFbot, once you do that, move to the helios slug bug | 17:14 |
| replaceafill | GFbot, ok? | 17:14 |
| GFbot | k | 17:14 |
| replaceafill | GFbot, cool, thanks | 17:15 |
| replaceafill | ACTION returns to gallaudet work | 17:15 |
| GFbot | ACTION goes to pick his brother | 17:48 |
| *** mjsir911 has joined #novawebdev | 19:05 | |
| *** mjsir911 has joined #novawebdev | 20:17 | |
| *** mjsir911 has joined #novawebdev | 20:34 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!