IRC log of #novawebdev for Wednesday, 2018-10-03

« Tuesday, 2018-10-02 Index Thursday, 2018-10-04 »
*** mjsir911 has joined #novawebdev08:18
*** replaceafill has joined #novawebdev10:55
*** mr_german has joined #novawebdev11:51
*** mjsir911 has joined #novawebdev12:47
mr_germanACTION goes to lunch brb14:18
replaceafillACTION goes to pick up his daughter, bb at 4pm14:46
mr_germanACTION is back15:51
mr_germanreplaceafill, are you there?16:21
replaceafillmr_german, yes16:24
mr_germanreplaceafill, im stuck with something16:24
mr_germanmaybe you can help me16:24
replaceafillmr_german, what is it?16:24
mr_germanim working on issue for groups16:24
mr_germanreplaceafill, i found the problem16:25
mr_germanbut, when i fix it16:25
mr_germanthe change doesn't work16:25
replaceafillmr_german, show me the fix16:25
mr_germanreplaceafill, https://pastebin.com/aQLgp2vc16:26
mr_germandetail.html template on user_groups16:26
replaceafillmr_german, that's not a diff16:26
replaceafillmr_german, show me a diff16:26
mr_germanoh16:26
mr_germanwait16:26
mr_germanreplaceafill, there you have 16:27
mr_germanhttps://pastebin.com/QHRVVihq16:27
replaceafillmr_german, yes that's what i remember being wrong16:29
replaceafillmr_german, what do you mean by "the change doesn't work"16:29
mr_germanreplaceafill, well as you can see, i changed it16:30
mr_germanbut it doesnt work16:30
mr_germanand16:30
mr_germani added and changed some lines to see if it is works16:30
mr_germanbut, it doesnt16:31
replaceafillmr_german, you're still not telling me why "it doesn't work"16:31
replaceafillmr_german, like what were you expecting and what happened instead16:31
mr_germanreplaceafill, well, i think if i change something in the template16:32
mr_germanand you see tendenci terminal or on browser16:32
mr_germanyou can not see changes16:32
replaceafillmr_german, i don't understand what you're talking about16:33
mr_germanreplaceafill, can i call you quickly?16:33
replaceafillmr_german, no16:34
mr_germanjust to explain that16:34
mr_german?16:34
replaceafillmr_german, try doing it here16:34
replaceafillmr_german, you suck at explaining yourself16:34
replaceafillmr_german, change that16:34
mr_germanlol16:34
replaceafillmr_german, btw pipe is not the same as slash16:34
replaceafillmr_german, you should fix your comment on the PR16:34
mr_germank16:35
replaceafillmr_german, you didn't mean "pipe" you meant "slash"16:35
mr_germanreplaceafill, thanks for that16:35
mr_germanreplaceafill, trato de decir que la template no hace caso a los cambios, he agregado lineas dummy para comprobar si aparecian y nada.16:36
mr_germanincluso intente borrar todo y ver si habia error, pero igual nada. como si la template llegara de otro lado.16:37
replaceafillmr_german, sigh... https://gitlab.com/novawebdevelopment/nova-base-theme/blob/master/templates/user_groups/detail.html16:39
replaceafillmr_german, you remember we have themes, right?16:39
replaceafillmr_german, maybe you're looking at a *themed instance*?16:39
mr_germandamn16:39
mr_germanomg16:40
replaceafillmr_german, tendenci 10116:40
replaceafill:P16:40
mr_germanreplaceafill, i feel so nooby lol16:41
mr_germanI was focus on tendenci716:41
replaceafillmr_german, don't worry i've been bit by that a lot too16:41
mr_germanbtw, it's fixed16:42
replaceafillmr_german, but you need to fix both16:42
mr_germansoo, i have to do a new pull request?16:42
mr_germanand create a new branch for this to our theme 16:42
replaceafillmr_german, first you have to fix the base themes16:42
mr_germanand then merge it16:42
mr_germanok16:42
replaceafillmr_german, then do a PR against tendenci11 since it includes the tendenci2018 theme16:43
mr_germanreplaceafill, can you point me to that branch?16:44
replaceafillmr_german, it's the master branch in tendenci's github16:44
mr_germanreplaceafill, oh, master is tendenci1116:45
mr_german?16:45
replaceafillmr_german, yes16:46
replaceafillmr_german, https://github.com/tendenci/tendenci/blob/master/tendenci/themes/t7-base/templates/user_groups/detail.html16:46
mr_germanreplaceafill, cool, thanks!16:46
replaceafillmr_german, don't touch t8-base btw16:47
mr_germank16:47
replaceafillmr_german, even though it has the same typo, tendenci.com doesn't want anyone messing with it16:47
mr_germancool16:48
mr_germanreplaceafill, but, tendenci11 has t7-base and t7-tendenci201816:49
mr_germanjust t7-tendenci2018 should i change16:49
mr_german?16:49
mr_germanor both16:49
mr_german?16:49
replaceafillmr_german, but t7-tendenci2018 doesn't have that template, does it?16:49
mr_germanreplaceafill, oh yeah, you right16:49
mr_germanreplaceafill, https://gitlab.com/novawebdevelopment/nova-base-theme/tree/gfbot/groups_self_removed_fixed16:55
replaceafillmr_german, you can just land that16:56
replaceafillmr_german, make sure it lands on every AMS branch16:56
replaceafillmr_german, + master16:56
mr_germanok16:56
mr_germanreplaceafill, the important ams right16:57
mr_german?16:57
replaceafillmr_german, which one is not important?16:57
mr_germanreplaceafill, ;) waiting for you to approve my merge to master16:58
replaceafillmr_german, oh wait16:58
replaceafillmr_german, i need to give you permissions on that now16:59
replaceafillmr_german, done17:00
replaceafillmr_german, you should be able to merge yourself now17:00
mr_germanreplaceafill, thanks!17:00
mr_germanreplaceafill, finally, now i have to merge them17:22
mr_germanlol17:22
replaceafillmr_german, it's part of the job17:22
mr_germanreplaceafill, i keep that in mind now ;)17:23
replaceafillmr_german, one day you'll come up with a better solution17:23
mr_germanreplaceafill, i hope that17:24
replaceafillACTION goes downstairs for a while17:28
mr_germanreplaceafill, https://gitlab.com/novawebdevelopment/nova-base-theme/branches/active doen17:31
mr_germandone*17:31
*** mjsir911 has joined #novawebdev18:18
« Tuesday, 2018-10-02 Index Thursday, 2018-10-04 »

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!