| thomasboimah | Yesterday I was working with Jallah online on Jetro website fixing link and button. No blocker. | 11:00 |
|---|---|---|
| zOnny | Hey team! Yesterday I reviewed the blog updates and kept things moving on that front. That said, I didn't make as much progress as usual yesterday due to my mother's birthday and some family gatherings. No Blockers | 11:00 |
| thomasboimah | ACTION done | 11:00 |
| zOnny | ACTION done | 11:00 |
| thomasboimah | Good morning zOnny | 11:01 |
| zOnny | Good morning thomasboimah | 11:01 |
| dcammue | Good morning zOnny | 11:01 |
| jelkner | Good morning zOnny! | 11:01 |
| jelkner | Sorry I'm late | 11:01 |
| zOnny | Good afternoon comrades | 11:01 |
| jelkner | i can't connect to irc when i turn my vpn on | 11:01 |
| thomasboimah | Happy Belated Birthday to you mom zOnny ! | 11:01 |
| thomasboimah | *your | 11:02 |
| jelkner | and i can't connect to my bank when i turn it off | 11:02 |
| zOnny | thomasboimah: thanks | 11:02 |
| jelkner | it was you're mom's b'day, zOnny? | 11:02 |
| jelkner | thomasboimah: how did you know that? | 11:02 |
| zOnny | jelkner: it was | 11:02 |
| jelkner | never mind | 11:02 |
| zOnny | jelkner: read the logs :) | 11:02 |
| jelkner | lol | 11:02 |
| jelkner | happy belated b'day to dear zOnny's mom! | 11:03 |
| zOnny | thanks | 11:03 |
| jelkner | so zOnny, did you get to look at thomasboimah's work on TheBlog? | 11:04 |
| zOnny | jelkner: I did | 11:04 |
| jelkner | as a user, i'm thrilled, but i'm looking for your feedback too | 11:04 |
| zOnny | jelkner: it is a solid work | 11:04 |
| jelkner | NICE! | 11:04 |
| zOnny | jelkner: but just one little thing missing there | 11:05 |
| jelkner | so now i need to find paid gigs for Jetro, zOnny | 11:05 |
| zOnny | jelkner: to confirm everything works as it should | 11:05 |
| jelkner | simple as that | 11:05 |
| jelkner | oh yes, it works great | 11:05 |
| zOnny | thomasboimah: I know, you know what I'm going to ask | 11:05 |
| dcammue | happy belated birthday to your Mom zOnny | 11:06 |
| jelkner | and the thing that makes customers smile so brightly is that he did everything from the user stories | 11:06 |
| jelkner | and just "made it work" | 11:06 |
| jelkner | so i logged on to blog again | 11:06 |
| jelkner | and everything was in place | 11:07 |
| jelkner | no hassle | 11:07 |
| zOnny | jelkner: great | 11:07 |
| zOnny | jelkner: this is the place we want to be | 11:07 |
| jelkner | just smooth, wonderful improvements | 11:07 |
| jelkner | +1 | 11:07 |
| jelkner | ok, i have a lot of banking stuff to do now | 11:07 |
| jelkner | my mortgage company sold the loan on our condo | 11:08 |
| zOnny | thomasboimah: are you familiar with C.I. pipeline? | 11:08 |
| thomasboimah | Yes | 11:08 |
| jelkner | so the autopay i used to depend on is gone | 11:08 |
| zOnny | thomasboimah: we will need that | 11:08 |
| jelkner | i'll let you two work | 11:08 |
| jelkner | zOnny: see you tuesday | 11:08 |
| jelkner | i hope we hear good news about AMS by then | 11:08 |
| zOnny | jelkner: yup | 11:08 |
| jelkner | if not, i'll ask if i should step in to see if i can help get it moving | 11:09 |
| jelkner | talk soon... | 11:09 |
| zOnny | jelkner: please | 11:09 |
| jelkner | will do zOnny | 11:09 |
| jelkner | ACTION signs off | 11:09 |
| jelkner has quit (Quit: Leaving) | 11:09 | |
| zOnny | thomasboimah: thanks for accomplishing the feature that your client (jelkner) was asking for | 11:10 |
| zOnny | thomasboimah: also you have upgraded the django version :) happy to see that | 11:11 |
| thomasboimah | Sure, Thank you too for the knowledge zOnny | 11:11 |
| zOnny | so as anything else you always craft your work | 11:11 |
| zOnny | thomasboimah: make sure other developers can run it without any issues | 11:12 |
| zOnny | what I usually do is reclone it and re install everything as I was I new user trying to run it in my machine just in case | 11:12 |
| zOnny | I'm sure most experienced developers have some better ways on verifying it | 11:15 |
| zOnny | thomasboimah: I just want to bring to your attention that two packages were missing in the requirements.txt | 11:19 |
| zOnny | thomasboimah: besides that I'm looking at your fake_pattern in blog/forms.py | 11:22 |
| thomasboimah | okay.. | 11:23 |
| zOnny | thomasboimah: I haven't used it before | 11:23 |
| thomasboimah | Sure. `fake_pattern` is a regular expression I added to help detect fake or placeholder email addresses before validation. I can explain how it works if you'd like, or if you think there's a more standard approach I'm happy to discuss it. | 11:25 |
| zOnny | thomasboimah: I was testing to see if it will reject legitimate emails | 11:27 |
| zOnny | the substring is a risky call | 11:27 |
| zOnny | thomasboimah: you can try with something like barbara.millers@gmail.com | 11:28 |
| thomasboimah | Thanks, that makes sense. I'll test it with legitimate email addresses like `barbara.millers@gmail.com` and review the pattern. If the substring check is too broad, I'll update it to avoid false positives. | 11:31 |
| zOnny | thomasboimah: Also the unique-character heuristic could reject legit short real emails. | 11:32 |
| zOnny | thomasboimah: https://gitlab.com/novawebdevelopment/the-blog/-/blob/jetroblog/blog/forms.py?ref_type=heads#L81 | 11:32 |
| zOnny | thomasboimah: there could be usernames such as bob@gmail.com or ana@gmail.com or others that will not pass the length ≥3 | 11:34 |
| zOnny | thomasboimah: I see why the use of this conditions | 11:35 |
| zOnny | thomasboimah: it is a good approach | 11:35 |
| thomasboimah | You're right. I was trying to filter out obviously fake addresses, but that rule is too restrictive since legitimate addresses can have usernames shorter than three characters. I'll remove that check and rely on `email-validator` for validation instead. | 11:36 |
| zOnny | thomasboimah: I will do the same if I do work in something like comments | 11:36 |
| thomasboimah | They reason why i can about using the fake_pattern expression is that the "email-validator" only validate the dns not the inbox | 11:40 |
| thomasboimah | *the | 11:40 |
| thomasboimah | *go | 11:40 |
| zOnny | thomasboimah: I see | 11:40 |
| zOnny | that is what I'm looking at | 11:40 |
| zOnny | thomasboimah: got it | 11:52 |
| zOnny | this is a Live DNS lookup on every comment POST | 11:53 |
| zOnny | thomasboimah: want to see my approach? | 11:59 |
| thomasboimah | yes | 11:59 |
| zOnny | thomasboimah: It is actually a minimal fix | 11:59 |
| zOnny | thomasboimah: I just push it | 12:11 |
| thomasboimah | ACTION going to check | 12:11 |
| zOnny | thomasboimah: I'm sure you are familiar with the Python's regular expresions module | 12:13 |
| thomasboimah | Thanks, I checked it out. I like the minimal approach. The regex-based username check is much safer than my substring matching, and skipping the deliverability lookup makes sense too. Thanks. | 12:16 |
| zOnny | thomasboimah: great | 12:18 |
| zOnny | thomasboimah: It is really your work on this, I was just testing it | 12:20 |
| zOnny | thomasboimah: so next step is to enable the C.I. pipeline | 12:20 |
| zOnny | thomasboimah: and update the README.md mentioning that using python3.12 is needed for running django5.2 | 12:21 |
| thomasboimah | sure | 12:22 |
| zOnny | thomasboimah: you are familiar with the .yml file yes? | 12:22 |
| thomasboimah | A little | 12:22 |
| zOnny | thomasboimah: nice | 12:22 |
| zOnny | thomasboimah: just see what we have done in the libreOrganize and BT | 12:23 |
| thomasboimah | okay | 12:23 |
| zOnny | thomasboimah: it should help you understand what you are asking the gitlab to run in order to pass the pipeline | 12:23 |
| zOnny | thomasboimah: I'm going to make coffee | 12:25 |
| thomasboimah | Okay | 12:25 |
| zOnny | thomasboimah: I was up late night yesterday watching the Argentinian Game :) | 12:26 |
| zOnny | ACTION goes to make coffe | 12:26 |
| zOnny | ACTION is back | 12:38 |
| zOnny | thomasboimah: do you have any questions? | 12:40 |
| resl has quit (Ping timeout: 480 seconds) | 12:40 | |
| thomasboimah | -1 for now | 12:40 |
| zOnny has quit (Remote host closed the connection) | 13:33 | |
| resl has quit (Remote host closed the connection) | 14:11 | |
| resl has quit (Remote host closed the connection) | 14:40 | |
| zOnny | thomasboimah: I'm going to drop off my dad | 15:32 |
| zOnny | If you need my help on anything I will be available on signal or email | 15:36 |
| thomasboimah | Okay | 15:55 |
| zOnny | thomasboimah: I have assigned to you the tasks for the blog | 15:56 |
| zOnny | thomasboimah: just to be consistent with assignments and track of work we do | 15:57 |
| thomasboimah | Okay | 15:57 |
| zOnny | thomasboimah: thanks again for getting the blog updated | 15:57 |
| zOnny | thomasboimah: It is good to count with someone that can help keep crafting our core projects | 15:58 |
| thomasboimah | Okay | 15:59 |
| zOnny | alright thomasboimah I'm going to sign off | 16:23 |
| thomasboimah | Okay zOnny thanks for today | 16:24 |
| zOnny | any questions? | 16:24 |
| zOnny | ACTION signs off for the day | 16:25 |
| zOnny has quit (Remote host closed the connection) | 16:25 | |
| thomasboimah has quit (Remote host closed the connection) | 19:35 | |
| dcammue has quit (Remote host closed the connection) | 20:13 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!